Moradin: Killing Duergar Lowers Favor

[Athon]

In all the canon sources I've read, Moradin is opposed to the Duergar and Derro and their gods. Thus, I don't see why a follower of Moradin should be losing favor when killing a Duergar.

Code: Select all

A duergar fighter is DEAD!
You sense that your patron is displeased by your actions.

[Solaghar]

Verified on the testport, problem is that the duergar parent is the dwarf race, so it considers duergar to be dwarves. This will be hard to fix, Drow would be considered Elves as well if this is the case. If we don't include parent races then shield dwarves are completely unrelated to dwarf effects from gold dwarves, both of whom would not truly be "dwarves". If we split duergar off, nothing that affects dwarves will affect duergar, which it should. But since duergar aren't a player race, my suggestion would be to split them off and just accept that any effect that affects dwarves won't affect duergar. There's a lot more dwarves killing duergar than there are duergar being affected by dwarf effects caused by weapons, spells or racial enemies.

[Nylo]

I don't know how the favor calculation is coded, but maybe something to the effect of

Code: Select all

if race($npc) == dwarf and race($npc) != duergar
-favor 
else if race($npc) == duergar
+favor
 endif

would work here?

[Harroghty]

I just set kill_npcrace to 0. That fixes the problem in the short term.